-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Cryptid codecs #345
base: master
Are you sure you want to change the base?
add Cryptid codecs #345
Conversation
Signed-off-by: Dave Grantham <dwg@linuxprogrammer.org>
The new Multisig and Multikey specs and implementations strictly follow:
This cannot be said for the existing Varsig spec. It relies heavily on context to know how to decode the bytes of the digital signature. More importantly, if your implementation doesn't support a specific algorithm, there is no way to know how many bytes to skip over in the stream to skip over the Varsig. Multisig fixes this as an explicit goal. |
Apologies for our slowness on this @dhuseby, both Volker and I are a bit stretched and you've given us a lot to review with your PRs and the cost of context switching to try and get our heads around all the new stuff in here isn't small. Firstly, the one we tend to be most concerned about is anything that adds
The new multi* entries will also require some additional thought and consideration. And due to the changes of the tags for existing entries we may need to pull in some folks who rely on those. |
Ah...ok. These are a new IPLD data structures but I think you're right,
This is a fair concern. I think to be safe, I'll just duplicate the overlap and assign new numbers. Let me fix this. |
Signed-off-by: Dave Grantham <dwg@linuxprogrammer.org>
Thank you for taking time to review this. I changed the provenance-log and provenance-log-entry to be |
Signed-off-by: Dave Grantham <dwg@linuxprogrammer.org>
I also just corrected the |
Signed-off-by: Dave Grantham <dwg@linuxprogrammer.org>
Also just cleaned up the |
I only had a quick look. We are generally pretty cautious adding anything into the number space which is encoded into a single byte as it is so limited (also some things that are already there shouldn't really, but that's hard to change). So if you would move your additions to a 2 bytes or higher section, that would be great. |
This adds a number of multicodec values for various Cryptid projects ahead of the public release of the code. Most of the code is already available:
*Contains the Nonce implementation as well. Spec