fix: avoid allocations in Display and Debug of Multiaddr
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
approved these changes
Nov 21, 2023
mxinden
reviewed
Nov 21, 2023
|
No, just happened to read these implementations by chance, and saw that they allocate. I remembered that we include them in a lot of log messages so I thought it might be worth sending a PR. Should I also write a changelog entry if I don't need a patch release? |
Fine without. Will be released whenever we cut a new release. Thank you! |
mxinden
approved these changes
Nov 21, 2023
mxinden
changed the title
Display and Debug implementationsDisplay and Debug of Multiaddr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.