Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add tab functionality to the logging area #3465

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

davidebeatrici
Copy link
Member

@davidebeatrici davidebeatrici commented Jul 12, 2018

This pull request is #179 updated.

To-do list:

  • When tab is too small to display full channel name then show it left aligned.
  • Bold font for the channel a user is currently in.
  • Add "Send message" to tab context menu (for formatted messages)?
  • Add checkbox next to chatbar for "tree" messages?
  • Chat tab does not automatically open for new messages from another channel.
  • Blinky blink on new messages.

Thanks to @Natenom for writing the list and testing the pull request.

Fixes #1884
Fixes #1839

@davidebeatrici davidebeatrici added client feature-request This issue or PR deals with a new feature priority/P1 - Critical labels Jul 12, 2018
@davidebeatrici davidebeatrici added this to the 1.3.0 milestone Jul 12, 2018
@davidebeatrici davidebeatrici changed the title Add tab functionality to the logging area [WIP] Add tab functionality to the logging area Jul 12, 2018
@davidebeatrici davidebeatrici force-pushed the log-tabs branch 11 times, most recently from da40883 to 8981d33 Compare July 17, 2018 01:56
@davidebeatrici davidebeatrici force-pushed the log-tabs branch 4 times, most recently from 8cda76a to 71bc965 Compare July 22, 2018 07:31
@Kissaki
Copy link
Member

Kissaki commented Jul 22, 2018

@davidebeatrici Why is this priority critical?

Urgent and Important, will STOP the release; Regressions from the last version that are not edge cases; Data loss; FTBFS for platforms we don't provide binaries for; All but the most unlikely crashes/lockups/hanging; Serious usability issues and embarrassing bugs; Bugs critical to a deliverable

@davidebeatrici
Copy link
Member Author

Changed to priority/P2 - Important:

Not Urgent, should be fixed, but will not stop the release.

@davidebeatrici davidebeatrici force-pushed the log-tabs branch 4 times, most recently from 3bf8a96 to c696585 Compare July 25, 2018 06:59
@davidebeatrici davidebeatrici modified the milestones: 1.3.0, 1.2.20, 1.4.0 Mar 3, 2019
@theAkito
Copy link

@davidebeatrici
Greetings,

I read that #88 was superseded by #1712 which was again superseded by this PR, namely #3465, which is at the same time supposed to be an updated version of #179 .

Does this mean that this Pull Request implements a chat log option? As far I as I have read, all these pull requests are pretty different from each other.

@davidebeatrici
Copy link
Member Author

@Akito13
Greetings,

This pull request doesn't implement a chat log feature, but it's planned.

#88 was closed because it has to be rewritten after the tab functionality is implemented.

#88 (comment) is confusing, sorry about that.

@Krzmbrzl
Copy link
Member

Krzmbrzl commented Nov 24, 2019

What's the status on this? Still WIP as the title suggests?

@davidebeatrici
Copy link
Member Author

Yes.

We actually wanted to finish this for 1.3.0, but unfortunately there was no time left after we fixed all the (high priority) issues.

@Natenom kindly wrote a to-do list for the feature, I'm going to write it in the pull request's message.

@Krzmbrzl Krzmbrzl linked an issue Mar 4, 2020 that may be closed by this pull request
@Kissaki Kissaki marked this pull request as draft December 24, 2020 09:40
@Kissaki Kissaki changed the title [WIP] Add tab functionality to the logging area WIP: Add tab functionality to the logging area Dec 24, 2020
@Kissaki Kissaki removed this from the 1.4.0 milestone Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature priority/P2 - Important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private messages in separate tabs Chat bar text desync CTRL+Enter to send direct chat messages
5 participants