feature/filters #348
Closed
feature/filters #348
+879
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds `amora.filters.DateFilter` - Adds `amora.filters.ValueFilter`
…quired` so that data is grouped by source_name
🤖 Gandalf - Continuos AppSecEste repositório está sendo monitorando de forma automática e contínua em busca de achados que possam comprometer à segurança da aplicação. Para maiores detalhes, acesse aqui à plataforma. |
diogommartins
added
help wanted
diogommartins
requested review from
thulio,
lemosflavio,
eduwxyz and
MirandaVic
diogommartins
commented
Apr 24, 2023
|
|
||
|
|
||
| def test_dashboard_with_value_filter(mock_dashboard_with_value_filter): | ||
| filtered_dashboard = mock_dashboard_with_value_filter.filter(source_name="iPhone") |
thulio
reviewed
May 5, 2023
| base = question.question_func().cte(question.question_func.__name__) | ||
| return select(base).where(base.c[self.field] == value) | ||
|
|
||
| question_func.__doc__ = question.question_func.__doc__ |
There was a problem hiding this comment.
Não dá para usar https://docs.python.org/3.10/library/functools.html#functools.wraps ?
There was a problem hiding this comment.
O problema aqui é "como criar em runtime uma função com __name__ e __doc__ específicos". Não consegui ver como seria possível fazer isso com functools.wraps. Consegue me ajudar?
thulio
previously approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amora.providers.bigquery.dry_run_queryamora.question.Question.answer_columnsamora.questions.parse_nameamora.filters.Filteramora.filters.DateRangeFilteramora.filters.AcceptedValuesFilteramora.dashboard.Dashboard.filteramora.dashboard.Dashboard.to_markdownhow_many_data_points_where_acquiredso that data is grouped by source_name