master: get graph width/height for html in graph-cgi mode also #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating html, if graph mode is cron, munin looks for the generated graph png files (from the previous run) to get width and height for the img elements, so that the page doesn't jump around for the few seconds it takes to download all the graph images. This can be done if graph mode is cgi, also, by looking in the cgitmpdir. Sometimes graph images won't be found, but if they are found they can be used. ----------------- This is admittedly a "hacky" implementation, and targetting the last stable branch instead of master. It is offered as an illustration of an idea that would be nice to have, if implemented properly. (The hacky implementation does work :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating html, if graph mode is cron, munin looks for the generated graph png files (from the previous run) to get width and height for the img elements, so that the page doesn't jump around for the few seconds it takes to download all the graph images. This can be done if graph mode is cgi, also, by looking in the cgitmpdir. Sometimes graph images won't be found, but if they are found they can be used.
This is admittedly a "hacky" implementation, targeting the last stable branch instead of master. It is offered as an illustration of an idea that would be nice to have, if implemented properly. (The hacky implementation does work!)
If you can recommend a strategy for implementing this "properly" I may attempt it :)