The function Client.wsdl.dump() was modified to allow to put the print output to a file or other stream. #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t output to a file or other stream. To the interface of the function was add a default parameter output=sys.stdout that keeps the current usability and permits flexility to change the output.
frost-nzcr4
reviewed
Aug 5, 2021
src/zeep/wsdl/wsdl.py
Outdated
| print("") | ||
| print("Prefixes:") | ||
| def dump(self, output=sys.stdout): | ||
| print("", file=output) |
There was a problem hiding this comment.
You can use local redefinition of print to avoid to set multiple file=output:
from functools import partial
print = partial(print, file=output)
print("")
print("Prefixes:")and file (as used in print) is better than output.
There was a problem hiding this comment.
@frost-nzcr4 I will performe the changes and submit another pull request.
renatodamas
added a commit
to renatodamas/python-zeep
that referenced
this pull request
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function Client.wsdl.dump() was modified to allow to put the print output to a file or other stream.
To the function interface was add a default parameter output=sys.stdout that keeps the current usability and permits flexility to change the output.
close #1212