Skip to content

Commit

Permalink
interp: skip TestRunnerTerminalExec/Pseudo on Mac
Browse files Browse the repository at this point in the history
While we can't reproduce the failures on Mac laptops, GitHub's Mac
machines fail this test pretty often. We can't have CI be that flaky.

Updates #513.
  • Loading branch information
mvdan committed Mar 27, 2020
1 parent 8bfaa27 commit ab43dfa
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions interp/terminal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"io"
"os"
"os/exec"
"runtime"
"strings"
"testing"

Expand Down Expand Up @@ -112,6 +113,9 @@ func TestRunnerTerminalExec(t *testing.T) {
for _, test := range tests {
test := test
t.Run(test.name, func(t *testing.T) {
if test.name == "Pseudo" && runtime.GOOS == "darwin" {
t.Skipf("too flaky on GitHub's Mac machines; see https://github.com/mvdan/sh/issues/513")
}
t.Parallel()

cmd := exec.Command(os.Getenv("GOSH_PROG"),
Expand Down

0 comments on commit ab43dfa

Please sign in to comment.