Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/shfmt: build with latest git tag as version #531

Merged
merged 1 commit into from Mar 27, 2020
Merged

cmd/shfmt: build with latest git tag as version #531

merged 1 commit into from Mar 27, 2020

Conversation

spieth
Copy link
Contributor

@spieth spieth commented Mar 27, 2020

This tries to fix #519.

@spieth
cmd/shfmt: build with latest git tag as version
1eea4d6 
Instead of a fixed string as version for development releases,
this injects the latest git tag as version during build and thus
allows to identify the binary later.

Fixes mvdan#519.
mvdan
mvdan approved these changes Mar 27, 2020
View reviewed changes
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - I agree this is good enough for now. We can move to the module versioning info later.

@mvdan mvdan merged commit 8c4fc3e into mvdan:master Mar 27, 2020
@spieth spieth deleted the dev-version branch March 27, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print a more useful string then 'devel'
2 participants
@spieth @mvdan