BUGFIX: line_kws.color is of no effect in distribution plot #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you provide a reproducible example of the issue? I am not sure this is a bug. |
Please see this notebook: https://colab.research.google.com/drive/1Ltc4lJzZjJXGyxdtlSOwtRGry2oMDWT6?usp=sharing |
MaozGelbart
reviewed
May 16, 2024
| @@ -647,7 +647,8 @@ def plot_univariate_histogram( | |||
| line_args = density, support | |||
| sticky_x, sticky_y = (0, np.inf), None | |||
|
|
|||
| line_kws["color"] = to_rgba(sub_color, 1) | |||
| line_color = line_kws.get('color', sub_color) | |||
| line_kws["color"] = to_rgba(line_color, 1) | |||
There was a problem hiding this comment.
This assignment breaks hue KDE line color (when not using line_kws) - it makes all KDE lines use the same color.
There was a problem hiding this comment.
Yes, you are right. The latest comment fixes this by reading the custom color value out of the hue for loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the distribution plot (such as
seaborn.histplot), bothcolorandline_kws['color']parameters are allowed to be passed to control the colors of bars and lines, respectively. However, current codes directly take the line color from the bar color while ignoring theline_kws['color']. This pull request fixes this by looking atline_kws['color']first, and adopting bar color only if the line color is not manually set.