Refactor Condition and Column Rendering #662
Merged
+1,103
−713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
RenderingContextwhich makes it easier to pass around the support objects necessary for rendering.The PR changes the rendering method for columns and functions such that they now receive the whole rendering context in their render methods. This allows for rendering of more complex functions (such as requested in #655)
The PR also changes the rendering method for conditions such that the rendering is only performed in the
DefaultConditionVisitor. Previously rendering was shared between that visitor and the conditions themselves which was confusing.Finally, the PR implements the change to the
sumfunction requested in #655.