Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

猬嗭笍 Upgrade all dependencies #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quilicicf
Copy link
Contributor

@quilicicf quilicicf commented Dec 11, 2019

There was a vulnerability on a dependency, seeing that almost all dependencies could use a bump I upgraded them all in the process.

The tests pass on my machine, let's see if they do on CI.

If you could release cpx when this gets merged it would be awesome 馃檹

@quilicicf
Copy link
Contributor Author

I checked why the tests fail on CI.

They do fail on NodeJS 6.5 because there are some rest/spread operators which are not supported in this version of NodeJS.

I didn't add them so I'm not sure how I should fix them (or even if I should do it).

Looks like there are two alternatives:

  • remove support for NodeJS 6.5, which is not supported anymore (I could do that easily)
  • revert the changes that broke the build on NodeJS 6.5 (but I suppose they were added knowingly and is not the way forward?)

Just tell me :)

@pReya
Copy link

pReya commented Dec 12, 2019

I'd really appreciate if this gets merged. Unfortunately this project hasn't been updated in a while. Hope it's not dead.

@quilicicf
Copy link
Contributor Author

Well if it is dead I might fork it but the support will be minimal, I don't know the code base at all....

@quilicicf
Copy link
Contributor Author

@mysticatea Are you still maintaining this?

@matthias-ccri
Copy link

@mysticatea might be dead too

@quilicicf
Copy link
Contributor Author

Someone seems to have developed a maintained replacement (cpx2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants