🐛 fix no-deprecated-api to hide unsupported alts correctly (fixes #176)

mysticatea · Sep 4, 2019 · b71d483 · b71d483
1 parent a0f0ee1
commit b71d483
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 6 deletions.
diff --git a/lib/rules/no-deprecated-api.js b/lib/rules/no-deprecated-api.js
@@ -662,13 +662,11 @@ function toReplaceMessage(replacedBy, version) {
 
     if (Array.isArray(replacedBy)) {
         message = replacedBy
-            .reduce(
-                (collector, { name, supported }) =>
-                    version.intersects(getSemverRange(`>=${supported}`))
-                        ? collector.concat(name)
-                        : collector,
-                []
+            .filter(
+                ({ supported }) =>
+                    !version.intersects(getSemverRange(`<${supported}`))
             )
+            .map(({ name }) => name)
             .join(" or ")
     }
 

diff --git a/tests/fixtures/no-deprecated-api/gte4/package.json b/tests/fixtures/no-deprecated-api/gte4/package.json
@@ -0,0 +1,5 @@
+{
+    "engines": {
+        "node": ">=4.0.0"
+    }
+}
diff --git a/tests/lib/rules/no-deprecated-api.js b/tests/lib/rules/no-deprecated-api.js
@@ -4,6 +4,7 @@
  */
 "use strict"
 
+const path = require("path")
 const { RuleTester } = require("eslint")
 const rule = require("../../../lib/rules/no-deprecated-api")
 
@@ -986,5 +987,18 @@ ruleTester.run("no-deprecated-api", rule, {
                 "'Buffer()' was deprecated since v6.0.0. Use 'Buffer.alloc()' or 'Buffer.from()' instead.",
             ],
         },
+
+        // https://github.com/mysticatea/eslint-plugin-node/issues/176
+        {
+            filename: path.resolve(
+                __dirname,
+                "../../fixtures/no-deprecated-api/gte4/test.js"
+            ),
+            code: "require('assert').equal",
+            env: { node: true },
+            errors: [
+                "'assert.equal' was deprecated since v10.0.0. Use 'assert.strictEqual' instead.",
+            ],
+        },
     ],
 })