New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: lint replaceBy messages #147
Conversation
Thank you for the fix! Would you fix the CI failure? (probably it will be fixed with |
OK, checking... |
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 98.21% 97.75% -0.47%
==========================================
Files 64 40 -24
Lines 1123 890 -233
==========================================
- Hits 1103 870 -233
Misses 20 20 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 64 64
Lines 1123 1123
=======================================
Hits 1103 1103
Misses 20 20
Continue to review full report at Codecov.
|
@mysticatea Updated :) |
Looks the test coverage has dropped, do I need to fill up the tests for the Node.js 10.0.0 cases? |
LGTM, thank you very much! |
Fixes #142
Node.js doc: