Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return value from updateMd5CacheItem #419

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mzgoddard
Copy link
Owner

Return a value so that a second call to updateMd5CacheItem on the
stored promise is given the input the first call received to keep from
throwing an error.

Return a value so that a second call to updateMd5CacheItem on the
stored promise is given the input the first call received to keep from
throwing an error.
@timneutkens
Copy link

It seems like this pull-request at least partially solves some of the issues users are having in #416, we got some reports from Next.js users too (Next.js now uses hard-source-webpack-plugin since version 7). @mzgoddard could you release this patch / is there anything I can do to help?

@towry
Copy link

towry commented Jan 14, 2019

@mzgoddard Any updates on this issue??

Update:

It already caused some UI broken in our app ...

@justrhysism
Copy link

@mzgoddard what can we do to help? I'm blocked from using this plugin until this bug is resolved (fails every time for me - applying the fix here resolves the issue).

@webdeb
Copy link

webdeb commented Mar 1, 2019

+1

@dbalatero
Copy link

There's a non-trivial amount of tests failing on CI, which I imagine is the cause for blocking here. If someone can fix the build that would probably unstick this PR. I don't know if @mzgoddard has any quick insights on what might be causing the test failures before anyone else dives in though?

@fabrianibrahim
Copy link

any updates on this?

@weilinzung
Copy link

any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants