Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check that frozen.build exists before trying to access it #497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

conorh
Copy link

@conorh conorh commented Apr 10, 2019

If there is a compilation where frozen.build is not generated for some reason then the check here would fail and throw an exception:

   Could not freeze FILE_NAME: Cannot read property 'hash' of undefined

Added check to see if the build exists, and then fall through to regenerate if it does not.

@conorh conorh changed the title Check that frozen.build exists before trying to access it fix: check that frozen.build exists before trying to access it May 29, 2019
If there is a compilation where frozen.build is not generated for some reason,
then the check here would fail and throw an exception:

   Could not freeze FILE_NAME: Cannot read property 'hash' of undefined

We check to see if the build exists and then fall through to regenerate if
it does not.
@larixer
Copy link

larixer commented Jun 28, 2019

@mzgoddard Can we have this merged?

@larixer
Copy link

larixer commented Sep 20, 2019

@mzgoddard Could you please, please review this PR and merge it? This problem is really a showstopper for us.

@eddieferrer
Copy link

Any update on merging this in?

@bovas85
Copy link

bovas85 commented May 3, 2020

bump

@elevatebart
Copy link

Can anyone look at the travis tests, see why they are not passing?

@ansballard
Copy link

So the tests aren't passing because npm run lint returns errors (calls prettier --list-different ...). Running npm run lint:fix should get travis to pass, as confirmed on a branch I made from this one. I actually went back a year or so in the travis build history and not a single run has succeeded, so we could merge this as is, especially since it's been tested via use of hard-source-webpack-plugin-fixed-hashbug.

TL;DR this looks perfectly safe to merge, with or without fixing the liner errors that are already in master anyway.

@dazjean
Copy link

dazjean commented May 14, 2021

m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants