Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useErrorHandler): handle incremental execution errors #2113

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrew0
Copy link

@andrew0 andrew0 commented Dec 9, 2023

Description

Updates useErrorHandler to include errors from incremental execution results.

Fixes #2112

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

How Has This Been Tested?

Added a unit test that was failing prior to the fix

Test Environment:

  • OS: Mac
  • @envelop/core: 5.0.0
  • NodeJS: 20.7.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: 458f236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@envelop/core Minor
@envelop/testing Major
@envelop/apollo-datasources Major
@envelop/apollo-federation Major
@envelop/apollo-server-errors Major
@envelop/apollo-tracing Major
@envelop/auth0 Major
@envelop/dataloader Major
@envelop/depth-limit Major
@envelop/disable-introspection Major
@envelop/execute-subscription-event Major
@envelop/extended-validation Major
@envelop/filter-operation-type Major
@envelop/fragment-arguments Major
@envelop/generic-auth Major
@envelop/graphql-jit Major
@envelop/graphql-middleware Major
@envelop/graphql-modules Major
@envelop/immediate-introspection Major
@envelop/live-query Major
@envelop/newrelic Major
@envelop/on-resolve Major
@envelop/opentelemetry Major
@envelop/operation-field-permissions Major
@envelop/parser-cache Major
@envelop/persisted-operations Major
@envelop/preload-assets Major
@envelop/prometheus Major
@envelop/rate-limiter Major
@envelop/resource-limitations Major
@envelop/response-cache Major
@envelop/sentry Major
@envelop/statsd Major
@envelop/validation-cache Major
@envelop/response-cache-cloudflare-kv Major
@envelop/response-cache-redis Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@EmrysMyrddin EmrysMyrddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution 😃 Very appreciated!

LGTM, just leaved a minor comment

packages/core/test/plugins/use-error-handler.spec.ts Outdated Show resolved Hide resolved
.changeset/breezy-feet-greet.md Outdated Show resolved Hide resolved
@andrew0 andrew0 changed the title fix(useErrorHandler): handle incremental execution errors feat(useErrorHandler): handle incremental execution errors Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useErrorHandler does not handle errors from incremental results
2 participants