Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth0): change Auth0 plugin audience property's type #2200

Merged
merged 2 commits into from
May 28, 2024

Conversation

KurtMar
Copy link
Contributor

@KurtMar KurtMar commented Mar 28, 2024

Description

Change type of Auth0 plugin's audience property to accept what the underlying jsonwebtoken library accepts. This is needed e.g. if the protected resource accepts JWTs from multiple applications.

Fixes # 2199

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

NA

How Has This Been Tested?

Tested using a @ts-ignored audience property and passing it an array of audiences.

Test Environment:

  • OS: MacOS
  • @envelop/auth0: 6.0.0
  • NodeJS: 20

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

This change is very limited as it is only a passthrough property that has a type available in the downstream package that has been implemented here as well.

Copy link

changeset-bot bot commented Mar 28, 2024

⚠️ No Changeset found

Latest commit: d2f77e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@EmrysMyrddin
Copy link
Collaborator

Let me rebase this PR, it should fix the CI

@EmrysMyrddin
Copy link
Collaborator

Thank you for your contribution! Very appreciated!

@EmrysMyrddin EmrysMyrddin merged commit 130aeb0 into n1ru4l:main May 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants