Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in utils.retry where delay is shared between calls #774

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug in utils.retry where delay is shared between calls #774

wants to merge 2 commits into from

Conversation

joechild-pace
Copy link

If a function decorated with utils.retry is called more than once, the backoff shouldn't accumulate between calls

@joechild-pace
Copy link
Author

It looks like github has dropped support for python 2.7 in setup-python actions/setup-python#672

The easiest fix is probably to remove it from CI (which I've done here) and look towards dropping support for it too

mattbennett
mattbennett approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@mattbennett mattbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and test.

Happy to drop 2.7 support here in CI. The next major release will drop it entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbennett mattbennett mattbennett approved these changes

@pace-gene pace-gene pace-gene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joechild-pace @mattbennett @pace-gene