Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Command Generator Location of Simple Example #898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

walidamriou
Copy link

@walidamriou walidamriou commented Sep 7, 2023

This pull request addresses the issue of the command generator location.

The change involves updating the command used for code generation from ../../generator-bin/protoc --nanopb_out=. simple.proto to ../../generator/protoc --nanopb_out=. simple.proto .

@walidamriou walidamriou changed the title Update README.txt Fix Command Generator Location of Simple Example Sep 7, 2023
@PetteriAimonen
Copy link
Member

Which platform is this for? Considering the makefile works for Linux (and OS X, BSD etc. even though readme doesn't say that) directly.

On Windows I guess it will work, if there is a suitable Python installation with necessary packages. Otherwise the binary package would be easier on Windows.

@walidamriou
Copy link
Author

This update effect README.txt only, the path of protoc is ../../generator/protoc --nanopb_out=. simple.protonot ../../generator-bin/protoc --nanopb_out=. simple.proto in examples/simple/README.txt

Tested in Windows

@PetteriAimonen
Copy link
Member

In the Windows binary packages, there is generator-bin/protoc instead. But yeah, it's not clear which would be better in the README.

@walidamriou
Copy link
Author

It's perfectly fine now. This is what I observed when using the master branch directly.

It's possible that if I use the Windows binary packages, the experience might be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants