Fix issues with removing listeners from the queue #302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After switching to the
next
branch I discovered several issues introduced by #280:index
instead ofqueueIndex
tolistenerQueue.splice
. In addition to being the wrong index, this can putlistenerQueue
into a really weird/bad state whenindex
is not divisible by 4 (sincelistenerQueue
uses chunks of 4 items per listener).set
on the same store multiple times inside a listener)splice
)listenerQueue
forlistener
, but as mentioned above, only every 4th item is a valid position to search in. This meant that if a listener function was set as the value of a store, it would be incorrectly found as a listener, andlistenerQueue
would end up in a bad state. This is an unlikely scenario to happen in the real world, but easy enough to fix.I added tests for all of those and fixed the issues.
cc @gismya