Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clone repository to subdirectory in examples test #6181

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Aug 22, 2023

Description

Test of examples starts failing as tox no longer discover tox.ini in a subfolder and/or do not allow non-defined environments

tox-dev/tox#3089

@brisvag
Copy link
Contributor

brisvag commented Aug 22, 2023

IIRC the subdirectory thing was in order to ensure it was indeed the recently pulled code that was being used correctly... Is that not a concern here? Or maybe I'm getting confused :P

@Czaki
Copy link
Collaborator Author

Czaki commented Aug 22, 2023

IIRC the subdirectory thing was in order to ensure it was indeed the recently pulled code that was being used correctly... Is that not a concern here? Or maybe I'm getting confused :P

All other tests are performed without cloning to subdirectory. Also, test on the main branch (comprehensive) are done without it. For me it looks like unnecessary complexity.

Other possible workarounds is to run test from subdirectory (change invoke command)

@brisvag
Copy link
Contributor

brisvag commented Aug 22, 2023

I guess it's fine then 🤷

@Czaki
Copy link
Collaborator Author

Czaki commented Aug 22, 2023

Could I merge it without waiting?

@brisvag brisvag merged commit 1064695 into napari:main Aug 22, 2023
29 checks passed
@Czaki Czaki deleted the bugfxi/tox_configuration branch August 22, 2023 14:53
@jni
Copy link
Member

jni commented Aug 22, 2023

@Czaki did you miss a line maybe?

Screenshot 2023-08-22 at 11 01 27 pm

Anyway, it looks like it was added in #5439. I'm not sure why — the previous usage was in the pip install section because installing with git+https: would pull down LFS files.

@Czaki
Copy link
Collaborator Author

Czaki commented Aug 22, 2023

I miss. But the test are at least working :P

I will fix it in #6156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants