Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi-derive): remove ts type on field attrs for feature noop #1436

Merged
merged 1 commit into from Jan 12, 2023
Merged

fix(napi-derive): remove ts type on field attrs for feature noop #1436

merged 1 commit into from Jan 12, 2023

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jan 11, 2023 •
edited

Fix a macro expand issue where the compiler complains napi is not a non-macro attribute if feature is set to noop.

#[napi(object)]
struct Foo {
  #[napi(some_arguments)]
    ^^^^ not a non-macro attribute
  bar: bool
}

closes #1271

@h-a-n-a h-a-n-a changed the title fix: remove ts type on field attrs fix: remove ts type on field attrs for feature noop Jan 11, 2023
@h-a-n-a h-a-n-a changed the title fix: remove ts type on field attrs for feature noop fix(napi-derive): remove ts type on field attrs for feature noop Jan 11, 2023
@Brooooooklyn Brooooooklyn merged commit 976acc7 into napi-rs:main Jan 12, 2023
@h-a-n-a h-a-n-a deleted the fix/ts-type-on-struct branch January 12, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested napi derive failed to work with napi-derive/noop
2 participants
@h-a-n-a @Brooooooklyn