Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): fix union type generation for ts function notation #1439

Merged
merged 3 commits into from Jan 14, 2023
Merged

fix(backend): fix union type generation for ts function notation #1439

merged 3 commits into from Jan 14, 2023

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Jan 14, 2023 •
edited

Fix a type generation error where a function type is used in a union type.

closes #1358

@h-a-n-a h-a-n-a force-pushed the fix/type-gen branch 3 times, most recently from b7fafef to abd7063 Compare January 14, 2023 07:44
@Brooooooklyn Brooooooklyn merged commit 78b6e15 into napi-rs:main Jan 14, 2023
@h-a-n-a h-a-n-a deleted the fix/type-gen branch January 14, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dts generation error for Either types
2 participants
@h-a-n-a @Brooooooklyn