Use the correct variable for lzards launchpad secret value #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jkovarik
reviewed
Nov 27, 2023
| @@ -99,7 +99,7 @@ resource "aws_secretsmanager_secret" "lzards_launchpad_passphrase" { | |||
| resource "aws_secretsmanager_secret_version" "lzards_launchpad_passphrase" { | |||
| count = length(var.lzards_launchpad_passphrase) == 0 ? 0 : 1 | |||
| secret_id = aws_secretsmanager_secret.lzards_launchpad_passphrase[0].id | |||
| secret_string = var.launchpad_passphrase | |||
| secret_string = var.lzards_launchpad_passphrase | |||
There was a problem hiding this comment.
Good catch - we are going to have to highlight this/note it in release migration instructions as there probably are users using a common token for both at this point.
|
Closing for: #3574 |
|
@reweeden I added a ticket to cover this (https://bugs.earthdata.nasa.gov/browse/CUMULUS-3580) - on review of the changes @jennyhliu pointed out that our current launchpad caching assumes a single cache file object (we recommended that users use the same TSA/lzards task configuration). I'm going to update that ticket with this information and we'll either put 3580 up for prioritization or open a new ticket. See review of #3574 for more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix
lzards_launchpad_passphrasesecret value.I was told there are known issues with LZARDS and launchpad, however I was unable to find any cumulus tickets associated with them. Could be my lack of familiarity with the ticketing system.
Changes
PR Checklist