code coverage with babel istanbul

[trusktr]

Closes

Describe your changes:

replaces instanbul-intrumenter-loader with babel-plugin-istanbul. Vue <script>s are now covered, but not expressions in <template>

• remove bad plugin/package and config
• add new package and config
• remove legacy-peer-deps option
• code coverage to be correct
• code coverage to work codecov.io
• provide path towards coverage being usable in e2e tests
• verify internal consumers still build and work fine

The previous instanbul-intrumenter-loader is outdated and abandoned with old Babel dependencies, so as our tooling progresses, it will be incompatible, and it crashes on any new syntax that all modern browsers already support without compiling or poyfilling those features.

This updates to use babel-plugin-istanbul which is maintained, so that it will stay up to date with Babel and latest syntaxes.

This also moves the converage instrumentation webpack config out of karma config into a separate webpack.coverage.js file, which can enable our other test environments besides Karma to also use it (not part of this PR).

All Submissions:

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

• Changes address original issue?
• Unit tests included and/or updated with changes?
• Command line build passes?
• Has this been smoke tested?
• Testing instructions included in associated issue?

To test: run npm run build:coverage and verify that the output in dist has coverage instrumentation (you'll see weird statements injected all over the JS code, but if you see only your plain JS code and nothing strange, then it didn't work).

Reviewer Checklist

• Changes appear to address issue?
• Changes appear not to be breaking changes?
• Appropriate unit tests included?
• Code style and in-line documentation are appropriate?
• Commit messages meet standards?
• Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
• Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

[trusktr]

hey @unlikelyzero , I see you approved. Are you okay with it not covering Vue code? Also I need to rebase this once both eslint PRs are merged. Then we can see if it'll pass.

[unlikelyzero]

Yea that's fine for now

[akhenry]

Still needed in light of using code cov?

[shefalijoshi]

@trusktr Please resolve conflicts. Also, @unlikelyzero , @nikhilmandlik , @trusktr Do we still need this? Discuss and close as needed.

[codecov]

Codecov Report

Merging #4649 (4f5e8ec) into master (b347f35) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4649      +/-   ##
==========================================
+ Coverage   50.36%   50.44%   +0.08%     
==========================================
  Files         510      511       +1     
  Lines       18657    18665       +8     
  Branches     1657     1644      -13     
==========================================
+ Hits         9396     9415      +19     
+ Misses       8847     8835      -12     
- Partials      414      415       +1     

Impacted Files	Coverage Δ
src/plugins/notebook/components/Notebook.vue	22.30% <0.00%> (-1.27%)	⬇️
.../notebook/components/NotebookSnapshotIndicator.vue	70.83% <0.00%> (-1.17%)	⬇️
src/ui/inspector/details/Properties.vue	62.50% <0.00%> (-0.66%)	⬇️
...gins/condition/components/inspector/StylesView.vue	47.66% <0.00%> (-0.30%)	⬇️
src/plugins/notebook/components/NotebookEmbed.vue	0.00% <0.00%> (ø)
src/plugins/plot/lib/eventHelpers.js	86.20% <0.00%> (ø)
...plugins/displayLayout/components/DisplayLayout.vue	2.06% <0.00%> (+<0.01%)	⬆️
src/plugins/displayLayout/components/LineView.vue	1.81% <0.00%> (+0.01%)	⬆️
...pi/forms/components/controls/AutoCompleteField.vue	1.96% <0.00%> (+0.03%)	⬆️
src/plugins/notebook/components/PageCollection.vue	2.85% <0.00%> (+0.07%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b347f35...4f5e8ec. Read the comment docs.

The base branch was changed.

[trusktr]

I was unable to get instrumentation into the JS expressions inside <template>s of Vue components. I asked a couple questions for ideas here:

• unable to instrument Vue template code when using vue-loader istanbuljs/babel-plugin-istanbul#273
• Any idea how to get this to use babel-plugin-istanbul for coverage in templates? JuniorTour/vue-template-babel-compiler#38

[jvigliotta]

@trusktr @unlikelyzero can you guys get together on this one?

[github-actions]

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2025319708

[github-actions]

Started e2e Run. Follow along: https://github.com/nasa/openmct/actions/runs/2025319708

[unlikelyzero]

We did a virtual walkthrough of the changes and potential impacts downstream.

[github-actions]

Success ✅ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2025319708

[github-actions]

Success ✅ ! Build artifacts are here: https://github.com/nasa/openmct/actions/runs/2025319708