Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If display bounds are out of sync with time conductor, don't purge data out of bounds #7732

Merged
merged 9 commits into from
Jun 3, 2024

Conversation

shefalijoshi
Copy link
Contributor

@shefalijoshi shefalijoshi commented May 14, 2024

Closes #6460

Describe your changes:

In addition to panning and zooming, also check if we're paused to not purge data out of bounds.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@shefalijoshi shefalijoshi added this to the Target:4.0.1 milestone May 14, 2024
@shefalijoshi shefalijoshi requested a review from akhenry May 14, 2024 18:55
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.66%. Comparing base (eba6f0f) to head (dce6ffd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7732   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files         673      673           
  Lines       27177    27177           
  Branches     2636     2636           
=======================================
  Hits        15399    15399           
  Misses      11447    11447           
  Partials      331      331           
Flag Coverage Δ
e2e-full 23.57% <ø> (ø)
e2e-stable 60.60% <ø> (-0.02%) ⬇️
unit 49.28% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
src/plugins/plot/MctPlot.vue 38.81% <100.00%> (ø)
src/plugins/timeConductor/TimePopupRealtime.vue 29.72% <ø> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba6f0f...dce6ffd. Read the comment docs.

@akhenry
Copy link
Contributor

akhenry commented May 21, 2024

Tests, please. Nothing should be pushed any more without tests.

Create new test spec for plot controls
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor e2e test changes

e2e/appActions.js Outdated Show resolved Hide resolved
e2e/appActions.js Outdated Show resolved Hide resolved
e2e/appActions.js Outdated Show resolved Hide resolved
@shefalijoshi shefalijoshi requested review from ozyx and akhenry May 31, 2024 19:00
ozyx
ozyx previously requested changes May 31, 2024
Copy link
Member

@ozyx ozyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are failing

@ozyx ozyx modified the milestones: Target:4.0.1, Target:4.0.0 May 31, 2024
@akhenry
Copy link
Contributor

akhenry commented Jun 1, 2024

Tests are passing, now there's a simple spelling mistake causing linting to fail :)

@akhenry
Copy link
Contributor

akhenry commented Jun 1, 2024

But hey, the spellchecker caught something, that's cool!

@akhenry akhenry enabled auto-merge (squash) June 3, 2024 15:39
@akhenry akhenry dismissed ozyx’s stale review June 3, 2024 15:40

Issues addressed

@akhenry akhenry added the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 3, 2024
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Jun 3, 2024
@akhenry akhenry merged commit c354e1c into master Jun 3, 2024
21 checks passed
@akhenry akhenry deleted the fix-plot-data-purge-paused branch June 3, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plots should not purge data that's out of bounds if it is paused
4 participants