Fixes Windows error message due to incorrect type comparison. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, I only see `Some dependencies may be missing from your system.` even though the value of `config_value` is `('posix',)`. This is because the type comparison is wrong, it checks that the tuple `('posix',)` is in `('posix', 'bash')`, instead of checking the string `posix`.
This PR fixes it by doing a set subset check.
nat-n
approved these changes
Mar 16, 2024
|
Hey @BertrandBordage, thanks for the contribution! |
nat-n
pushed a commit
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, I only see
Some dependencies may be missing from your system.even though the value ofconfig_valueis('posix',). This is because the type comparison is wrong, it checks that the tuple('posix',)is in('posix', 'bash'), instead of checking the stringposix.This PR fixes it by doing a set subset check.