Return cleo application exit code from monkeymatch #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @monim67, thanks for the fix! Looks like I have some issues to fix with the CI pipeline, but Ill try get this into a release soon. |
|
Errors seem unrelated |
nat-n
force-pushed
the
bugfix/return-cleo-exit-code
branch
from
ee84641
to
edff89f
Compare
- Fix poetry plugin tests with latest poetry version - Remove new lines from args in script tasks - Also look for .com and .bat files in venv bin dir on windows - Skip unncessary poetry configuration step in plugin tests
nat-n
force-pushed
the
bugfix/return-cleo-exit-code
branch
from
edff89f
to
0af206f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monkeypatch poethepoet plugin does on cleo application does not return the exit code returned by the command execution.
This PR returns the exit code from the application run patch function. Fixes #91.