add http API interface #110
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natenho Do you have any ideas? |
|
Hi @wlclass, I'm going to review as soon as possible and we can discuss about it! Thank you for your contribution!! |
natenho
reviewed
Jun 9, 2023
| @@ -13,6 +14,8 @@ public static IApplicationBuilder UseMockaco(this IApplicationBuilder app, Actio | |||
| var options = app.ApplicationServices.GetRequiredService<IOptions<MockacoOptions>>().Value; | |||
| app.UseEndpoints(endpoints => endpoints.Map($"/{options.VerificationEndpointPrefix}/{options.VerificationEndpointName}", VerifyerExtensions.Verify)); | |||
|
|
|||
| app.UseEndpoints(endpoints => endpoints.Map($"/{options.AdminApiEndpointPrefix}/{options.AdminApiEndpointName}/{{action}}", AdminApiExtensions.Handler)); | |||
There was a problem hiding this comment.
Have you considered using restful actions? i.e. use HTTP verbs to represent actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an http api to the project to manage the template's three interfaces:
POST or GET: /{Endpoint}/list
POST: /{Endpoint}/remove
POST: /{Endpoint}/update
The Endpoint can be configured in MockacoOptions, and a simple authentication is added for the api interface, which requires a security key to be provided through the token query parameter.
This is a sloppy pr, but hopefully it will help.
Associated issue: #66 #102