forked from vercel/next.js
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: update firebase in with-firebase (vercel#29581)
From issue vercel#29569 that mention `with-firebase` will error when use `measurementId`. I update firebase in this example and changed code into firebase 9 and that error is disappeared. Closes: vercel#29570 Fixes: vercel#29569
- Loading branch information
Showing
4 changed files
with
35 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,26 @@ | ||
import firebase from 'firebase/app' | ||
import 'firebase/auth' // If you need it | ||
import 'firebase/firestore' // If you need it | ||
import 'firebase/storage' // If you need it | ||
import 'firebase/analytics' // If you need it | ||
import 'firebase/performance' // If you need it | ||
|
||
const clientCredentials = { | ||
apiKey: process.env.NEXT_PUBLIC_FIREBASE_API_KEY, | ||
authDomain: process.env.NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN, | ||
databaseURL: process.env.NEXT_PUBLIC_FIREBASE_DATABASE_URL, | ||
projectId: process.env.NEXT_PUBLIC_FIREBASE_PROJECT_ID, | ||
storageBucket: process.env.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET, | ||
messagingSenderId: process.env.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID, | ||
appId: process.env.NEXT_PUBLIC_FIREBASE_APP_ID, | ||
} | ||
import { initializeApp, getApps } from 'firebase/app' | ||
import { getAnalytics } from 'firebase/analytics' | ||
export const createFirebaseApp = () => { | ||
const clientCredentials = { | ||
apiKey: process.env.NEXT_PUBLIC_FIREBASE_API_KEY, | ||
authDomain: process.env.NEXT_PUBLIC_FIREBASE_AUTH_DOMAIN, | ||
databaseURL: process.env.NEXT_PUBLIC_FIREBASE_DATABASE_URL, | ||
projectId: process.env.NEXT_PUBLIC_FIREBASE_PROJECT_ID, | ||
storageBucket: process.env.NEXT_PUBLIC_FIREBASE_STORAGE_BUCKET, | ||
messagingSenderId: process.env.NEXT_PUBLIC_FIREBASE_MESSAGING_SENDER_ID, | ||
appId: process.env.NEXT_PUBLIC_FIREBASE_APP_ID, | ||
measurementId: process.env.NEXT_PUBLIC_FIREBASE_MEASUREMENT_ID, | ||
} | ||
|
||
if (!firebase.apps.length) { | ||
firebase.initializeApp(clientCredentials) | ||
// Check that `window` is in scope for the analytics module! | ||
if (typeof window !== 'undefined') { | ||
// Enable analytics. https://firebase.google.com/docs/analytics/get-started | ||
if ('measurementId' in clientCredentials) { | ||
firebase.analytics() | ||
firebase.performance() | ||
if (getApps().length <= 0) { | ||
const app = initializeApp(clientCredentials) | ||
// Check that `window` is in scope for the analytics module! | ||
if (typeof window !== 'undefined') { | ||
// Enable analytics. https://firebase.google.com/docs/analytics/get-started | ||
if ('measurementId' in clientCredentials) { | ||
getAnalytics() | ||
} | ||
} | ||
return app | ||
} | ||
} | ||
|
||
export default firebase |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters