Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace write-file-atomic with atomically #174

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Replace write-file-atomic with atomically #174

merged 1 commit into from
Apr 18, 2023

Conversation

quanglam2807
Copy link
Collaborator

@quanglam2807 quanglam2807 commented Apr 18, 2023

Resolve #159
Resolve #169

CC: @nathanbuchar

Reference: sindresorhus/electron-store#103

@nathanbuchar
Copy link
Owner

Thank you!

@nathanbuchar nathanbuchar merged commit 84e5ff6 into nathanbuchar:master Apr 18, 2023
@nathanbuchar
Copy link
Owner

I'll deploy this tonight.

@quanglam2807
Copy link
Collaborator Author

Thanks so much, @nathanbuchar. For releasing, you'll probably need to modify src/settings.ts to drop remote support.

You can check out my fork for referencing: quanglam2807@9db71fd#diff-bb57a3bd912abc3ec2e729cb8a743838487677a5517683d0c8913a3619ac296a

If possible, I'd love to join as a maintainer of this project.

@nathanbuchar
Copy link
Owner

@quanglam2807 sorry, didn't get around to it tonight. I'd be happy to add you as a maintainer, as I haven't used Electron in years. if you get this fully ready, I'll publish a new version.

@quanglam2807
Copy link
Collaborator Author

Np! Please add me as GitHub maintainer, @nathanbuchar. We'll need to do multiple things (multiple PRs) to get the project back to track so it would be much more productive if I'm a maintainer.

@nathanbuchar
Copy link
Owner

I sent the Github collaborator invite over to you last night, but I see it's still marked as pending.

@quanglam2807
Copy link
Collaborator Author

@nathanbuchar Thank you! It's ready for release now.

@nathanbuchar
Copy link
Owner

Excellent. Many thanks for your help and your agency for keeping this repository properly maintained. I have just published v5.0.0 to npm (@latest). Please install the latest version and make sure everything was properly published and working as expected.

For future reference, I run npm run release to automatically boost the version number and update the changelog, so as long as you use the Conventional Commits spec correctly, the release script will automatically boost to the proper semantic version without needing to modify the package.json manually.

I don't suppose the tests are working with your most recent changes? I wasn't able to test things locally, but I don't currently have Electron installed. Would be good to have tests functional in some sort of CI (I was using Travis before) as a sanity test for future PRs.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants