Improve Spring Animation example #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfebert
commented
Aug 8, 2018
ralfebert
commented
- Continuously animate between two states (left and right) using layout constraints to avoid the jumpiness of resetting the position
- Removing terms bounciness and speed (I like these terms, but they can be confusing because their ranges are opposite: low damping = high bounciness, short response = high speed)
- Make value labels more clear by adding units (50% damping, 1s response instead of 0.5 and 1.0)
ralfebert
force-pushed
the
master
branch
2 times, most recently
from
a8a9679
to
9cc4420
Compare
* Continuously animate between two states (left and right) using layout constraints to avoid the jumpiness of resetting the position * Removing terms bounciness and speed (these are confusing because their ranges are opposite: low damping = high bounciness, short response = high speed) * Make value labels more clear by adding units (50% damping, 1s response instead of 0.5 and 1.0)
|
I like these changes. Feels smoother and friendlier. Not sure about removing the "bounciness" and "speed" labels, although I agree the opposite ranges are confusing. I need to give it some more thought. (Also, this code is outputting constraint errors when I run it on an iPhone X. I'm running Xcode 10 and iOS 12.) |
|
Layout warning should be fixed now. Hmm, about the labels, one way to have them without being misleading would be adding an explicit explanation like "low damping = high bounciness". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.