This repository has been archived by the owner on Sep 29, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamp and move to TypeScript #898
Revamp and move to TypeScript #898
Changes from 50 commits
90df289
8a2fa24
3bc64c1
b99702a
e257c27
5d2fb00
a9925ee
85a728a
86093d8
833d161
da28422
bb654e4
f325e42
95d9444
b7b7be6
e2970f2
9c8e453
4a4db01
eb7b414
24bcbab
d517054
2fbb558
9a5de4a
ab4c88c
b29203c
853c7cb
cc9ab2e
02fa134
79c2c93
8914408
18d6020
1846489
4c9f4b8
234fc73
3396792
fdd64ba
a0a94ef
1de1bf1
2a727b1
b9ad2c5
da3e15f
64fb1eb
5600356
03dfd80
08385ee
025e78b
98504c8
2248014
bff5012
135a807
079f842
dec386b
3875743
f1686f4
83ccda1
17e7cbf
4fdd1b4
467d4c9
19e4e4c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this comment mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiahaog see a few lines below; with the addition of {Windows, macOS} platforms in Travis, CI duration lengthened, so I added a condition restricting the linter to run only on a single sub-build, to shave off 10s * 8 from the build:
I just pushed a little improvement of the comment to clearer
# Changing this? Remind to adjust the linter condition below causing linter to run for only one version (for faster CI)
@jiahaog welcome 🙂, and thanks for the final tests. I use lots of open-source software at home and at work, this is for me an occasion to give back in a context that I know (I do TS at work these days), and contribute a lot by cleaning & strengthening a codebase that needed it. The last few weeks I got confident that at least common use cases will be fine, as:
There will inevitably be regressions given the amount of changes, but I'm not anticipating a tornado of bug reports. I'm subscribed to issues notifications and will keep a close eye on them after releasing, fixing regressions quickly in patch versions.
@jiahaog I'll be merging this as 8.0.0 today or next week, with the description of this PR as release notes. I will squash (a few squashes already happened, for rebase simplicity). I don't anticipate needing help merging & publishing (the normal release process should work), but will ping you if something I forgot about goes wrong.
Thanks for the support and reviews, cheers!
This file was deleted.