Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ADR 8 KV Status interface #159

Merged
merged 1 commit into from Sep 28, 2022
Merged

Update ADR 8 KV Status interface #159

merged 1 commit into from Sep 28, 2022

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Sep 23, 2022

Adds Bytes() to the bucket Status interface (see nats-io/nats.go#1092)

@jnmoyne jnmoyne mentioned this pull request Sep 23, 2022
Merged
tbeets
tbeets approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@tbeets tbeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbeets tbeets merged commit 6d59794 into main Sep 28, 2022
@scottf scottf deleted the jnm/adr8_23-Sept-23 branch September 29, 2022 15:32
@scottf scottf mentioned this pull request Sep 29, 2022
Open
12 tasks
@aricart aricart mentioned this pull request Sep 29, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbeets tbeets tbeets approved these changes

@ripienaar ripienaar Awaiting requested review from ripienaar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jnmoyne @tbeets