Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document multi get behaviours #268

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Document multi get behaviours #268

merged 2 commits into from
Mar 13, 2024

Conversation

ripienaar
Copy link
Contributor

No description provided.

Copy link
Member

@bruth bruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A couple questions and some grammatical edits.

adr/ADR-31.md Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Outdated Show resolved Hide resolved
adr/ADR-31.md Show resolved Hide resolved
Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar
Copy link
Contributor Author

Have pushed a squash here. Will keep open till we know if nats-io/nats-server#5158 lands

Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar ripienaar merged commit 19cb502 into main Mar 13, 2024
1 check passed
@ripienaar ripienaar deleted the multi_get branch March 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants