Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: allow for changing the namespace where operator runs #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

supriya-premkumar
Copy link

Changes:

Changes:
    1. Changed KubernetesNamespaceNatsIO to a var.
    2. This will allow a compile time override of nats namespace
    for advanced k8s admins to configure a non nats-io namespace for
    cluster scoped deployment.
    3. Enables workflows referred by nats-io#126
@pires
Copy link
Collaborator

pires commented Apr 10, 2019

@supriya-premkumar thank you for this contribution. Following #126, would you be open to work with me to evolve this PR into something that doesn't depend on having users building their own images?

@supriya-premkumar
Copy link
Author

@supriya-premkumar thank you for this contribution. Following #126, would you be open to work with me to evolve this PR into something that doesn't depend on having users building their own images?

Hi @pires I would be happy to help with this. Could you please give me pointers on where I can get started and Thank you for your time on this.

@pires
Copy link
Collaborator

pires commented Apr 10, 2019

Can I find you on NATS slack, @supriya-premkumar? Ping me @pires! Thanks a lot.

@pires pires self-assigned this Apr 10, 2019
@pires pires changed the title Changing KubernetesNamespaceNatsIO to var WIP: allow for changing the namespace where operator runs Apr 10, 2019
@ki0
Copy link

ki0 commented May 12, 2022

why isn't it merged? i'm very interested for this feature.

@pires
Copy link
Collaborator

pires commented May 13, 2022

The limitation here is that this requires users to build their own binaries/container images. I also think this would not work as expected given https://github.com/nats-io/nats-operator/blob/master/cmd/operator/main.go#L108-L112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants