Merge pull request #3975 from nats-io/neil/encbuffer

Use pooled buffer for flushing encrypted message blocks

server/filestore.go

@@ -3993,16 +3993,17 @@ func (mb *msgBlock) flushPendingMsgsLocked() (*LostStreamData, error) {
 
 	// Check if we need to encrypt.
 	if mb.bek != nil && lob > 0 {
-		const rsz = 32 * 1024 // 32k
-		var rdst [rsz]byte
+		// Need to leave original alone.
 		var dst []byte
-		if lob > rsz {
-			dst = make([]byte, lob)
+		if lob <= defaultLargeBlockSize {
+			dst = getMsgBlockBuf(lob)[:lob]
 		} else {
-			dst = rdst[:lob]
+			dst = make([]byte, lob)
 		}
-		// Need to leave original alone.
 		mb.bek.XORKeyStream(dst, buf)
+		if cap(buf) <= defaultLargeBlockSize {
+			recycleMsgBlockBuf(buf)
+		}
 		buf = dst
 	}