[FIXED] Consumer fixes and improvements on state management. #3892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General code cleanup to be more correct. Signed-off-by: Derek Collison <derek@nats.io>
Make sure to update ack floors on messages being expired out from underneath of us. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
approved these changes
Feb 20, 2023
Jarema
reviewed
Feb 20, 2023
|
|
||
| // Ack all again | ||
| for _, m := range msgs { | ||
| m.Ack() |
There was a problem hiding this comment.
Async, so no error will be propagated and the we do flush and the checks below on consumer info guarantee the acks were processed.
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
consumer-fixes
branch
from
83a68ba
to
3c64d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to also cleanup pending if below our stream ack floor.
Make sure to clean up redelivered state on purge.
Make sure to update ack floors on messages being expired out from underneath of us.
Fixed bug that would lose ack pending state during partial stream purge.
Make sure we warn properly of consumer state update failures.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core