Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Consumer fixes and improvements on state management. #3892

Merged
merged 4 commits into from Feb 21, 2023
Merged

[FIXED] Consumer fixes and improvements on state management. #3892

merged 4 commits into from Feb 21, 2023

Commits on Feb 19, 2023

  1. Fixed bug that would lose ack pending state during partial stream purge. 

    General code cleanup to be more correct.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    6c9a9fb View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Make sure to clean up redelivered state on purge. 

    Make sure to update ack floors on messages being expired out from underneath of us.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    b6149c5 View commit details
    Browse the repository at this point in the history

  2. Make sure to also cleanup pending if below our stream ack floor 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    d2179e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Warn of consumer state update failures. 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3c64d07 View commit details
    Browse the repository at this point in the history