[FIXED] Killed server on restart could render encrypted stream unrecoverable #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…covered the keyfile was removed and could cause the stream to not be recoverable. We only needed to delete the key file when converting ciphers and right before we add the stream itself. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
philpennock
reviewed
Jun 3, 2023
There was a problem hiding this comment.
This still leaves a window with no key on disk. Shouldn't it write the new key to a new file name before writing the data, close them both, then atomically rename the new keyfile over the old one? And do so with a predictable name so that recovery can detect the situation?
|
Yes you are correct and will look at that for 2.10 vs making that big of a change here. This is only for when you are converting ciphers. |
|
Meaning the server that is restarting is converting ciphers and its killed (kill -9) mid-way between a restore of a stream. |
|
Plus have more changes to encryption for 2.10, so won't make that change here. |
wallyqs
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a server was killed on restart before an encrypted stream was recovered the keyfile was removed and could cause the stream to not be recoverable.
We only needed to delete the key file when converting ciphers and right before we add the stream itself.
Signed-off-by: Derek Collison derek@nats.io
Resolves #4195