Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIXED] Killed server on restart could render encrypted stream unrecoverable #4210

Merged
merged 2 commits into from Jun 4, 2023
Merged

[FIXED] Killed server on restart could render encrypted stream unrecoverable #4210

merged 2 commits into from Jun 4, 2023

Commits on Jun 3, 2023

  1. When a server was killed on restart before an encrypted stream was re… 

    …covered the keyfile was removed and could cause the stream to not be recoverable.

We only needed to delete the key file when converting ciphers and right before we add the stream itself.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    d5ae96f View commit details
    Browse the repository at this point in the history

  2. Make sure to put the keyfile back if we did not recover the stream. 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    4c1b93d View commit details
    Browse the repository at this point in the history