New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADDED] Full StreamSource (filters, transforms) functionality to stream mirror #4354
Conversation
95aa322
to
78da4cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just few comments.
016a927
to
f4b9c5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…mirroring Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…ng a leader for the stream that uses a subject transform (besides being also checked during the stream create or update operation itself). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
f4b9c5f
to
500fa6e
Compare
…and mirror introduced in nats-io/nats-server#4354 Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…and mirror introduced in nats-io/nats-server#4354 Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
git pull --rebase origin main
)Follow up to #4276 extending to Mirror the full StreamSource functionality.