Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Full StreamSource (filters, transforms) functionality to stream mirror #4354

Merged
merged 6 commits into from Aug 12, 2023

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Aug 1, 2023

  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Follow up to #4276 extending to Mirror the full StreamSource functionality.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just few comments.

server/stream.go Outdated Show resolved Hide resolved
server/stream.go Outdated Show resolved Hide resolved
server/stream.go Outdated Show resolved Hide resolved
@jnmoyne jnmoyne force-pushed the jnm/stream_mirroring_multi_transforms branch 2 times, most recently from 016a927 to f4b9c5f Compare August 11, 2023 07:19
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

server/stream.go Outdated Show resolved Hide resolved
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…mirroring

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
…ng a leader for the stream that uses a subject transform (besides being also checked during the stream create or update operation itself).

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
@jnmoyne jnmoyne force-pushed the jnm/stream_mirroring_multi_transforms branch from f4b9c5f to 500fa6e Compare August 12, 2023 21:38
@jnmoyne jnmoyne merged commit b839c53 into dev Aug 12, 2023
2 checks passed
@jnmoyne jnmoyne deleted the jnm/stream_mirroring_multi_transforms branch August 12, 2023 22:17
jnmoyne added a commit to nats-io/nats-architecture-and-design that referenced this pull request Aug 29, 2023
…and mirror introduced in nats-io/nats-server#4354

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
jnmoyne added a commit to nats-io/nats-architecture-and-design that referenced this pull request Aug 29, 2023
…and mirror introduced in nats-io/nats-server#4354

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants