Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] client support for multi-subject transforms in sources and mirrors #1359

Merged
merged 8 commits into from Aug 15, 2023

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Aug 2, 2023

…onfig.go

Adds new multi-filter fields to StreamSource and StreamSourceInfo in jms.go and stream_config.go
…ter and subject transform fields when creating a stream, and add associated errors.
… 2.10 related source filter and subject transform fields when creating or updating a stream for the new JS API
Improves error message

Update go_test.mod to point to the branch of nats-server with the multifilter sourcing changes
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few nits

jetstream/jetstream.go Outdated Show resolved Hide resolved
jetstream/jetstream.go Outdated Show resolved Hide resolved
jetstream/errors.go Outdated Show resolved Hide resolved
jetstream/errors.go Outdated Show resolved Hide resolved
jetstream/errors.go Outdated Show resolved Hide resolved
jetstream/errors.go Outdated Show resolved Hide resolved
jetstream/jetstream.go Outdated Show resolved Hide resolved
jsm.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 6771268 into 2.10.0 Aug 15, 2023
2 checks passed
@piotrpio piotrpio deleted the jnm/29-jun-23 branch August 15, 2023 14:49
@piotrpio piotrpio mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants