Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some system service imports going missing after reload #4360

Merged
merged 3 commits into from Aug 2, 2023
Merged

Fix some system service imports going missing after reload #4360

merged 3 commits into from Aug 2, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Aug 2, 2023

On reload some of the imports from the system account where going missing on reload, this adds them back after a reload:

$SYS.REQ.SERVER.PING.CONNZ
$SYS.REQ.ACCOUNT.PING.STATZ
$SYS.REQ.ACCOUNT.PING.CONNZ

@wallyqs
Add test checking subscriptions before/after reload
13cb62e 
Signed-off-by: Waldemar Quevedo <wally@synadia.com>
@wallyqs wallyqs requested a review from a team as a code owner August 2, 2023 06:17
@wallyqs
fix: add missing default service imports on reload
2b25246 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
neilalexander
neilalexander approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs
review fixes
23b5cb9 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@derekcollison derekcollison self-requested a review August 2, 2023 17:13
derekcollison
derekcollison reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison self-requested a review August 2, 2023 17:13
derekcollison
derekcollison approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 5577d18 into main Aug 2, 2023
2 checks passed
@derekcollison derekcollison deleted the reload-delsub branch August 2, 2023 17:14
@wallyqs wallyqs mentioned this pull request Aug 4, 2023
Merged
wallyqs added a commit that referenced this pull request Aug 5, 2023
@wallyqs
Remove reload fix from main (#4369)
0e7394a 
The fix from #4360 will not work for v2.10 branch features so removing
from dev and working on a different PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @derekcollison @neilalexander