Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reload fix from main #4369

Merged
merged 1 commit into from Aug 5, 2023
Merged

Remove reload fix from main #4369

merged 1 commit into from Aug 5, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Aug 4, 2023

The fix from #4360 will not work for v2.10 branch features so removing from dev and working on a different PR.

@wallyqs
Remove reload fix from main
eecb8af 
This workaround will not work for v2.10 branch features

Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner August 4, 2023 23:59
derekcollison
derekcollison approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - But let's get real fix back in asap.

@wallyqs wallyqs merged commit 0e7394a into dev Aug 5, 2023
2 checks passed
@wallyqs wallyqs deleted the remove-reload-fix-from-main branch August 5, 2023 00:29
@wallyqs wallyqs mentioned this pull request Aug 6, 2023
Merged
wallyqs added a commit that referenced this pull request Aug 7, 2023
@wallyqs
Fixes to service system imports on reload also when using custom syst…
abe0791 
…em account (#4372)

Adds back the fix from #4369 and also fixes the export that was going
missing in dev branch when a custom system account was being used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wallyqs @derekcollison