[IMPROVED] Delete blocks performance #4371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size of encoding may be a bit bigger then we wanted, but still way better then old method and very fast. Signed-off-by: Derek Collison <derek@nats.io>
…ng time for filestore. Revert back to very simple but way faster method. Sometimes 100x faster and only ~8% size increase. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track deleted with single avl.SeqSet dmap for now vs old method for memory store.
For fileStore, we were trying to be too smart to save space at the expense of encoding time, so revert back to simple version that is much 100x faster.
Size of encoding may be a bit bigger then we wanted, but we want to prefer speed over size.
Signed-off-by: Derek Collison derek@nats.io