Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Delete blocks performance #4371

Merged
merged 3 commits into from Aug 7, 2023
Merged

[IMPROVED] Delete blocks performance #4371

merged 3 commits into from Aug 7, 2023

Commits on Aug 5, 2023

  1. Track deleted with single avl.SeqSet dmap for now vs old method. 

    Size of encoding may be a bit bigger then we wanted, but still way better then old method and very fast.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    1f00d0e View commit details
    Browse the repository at this point in the history

  2. We were trying to be too smart to save space at the expense of encodi… 

    …ng time for filestore.

Revert back to very simple but way faster method. Sometimes 100x faster and only ~8% size increase.

Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    3b23505 View commit details
    Browse the repository at this point in the history

  3. No longer compacting multiple blocks, so remove test check 

    Signed-off-by: Derek Collison <derek@nats.io>
    @derekcollison
    derekcollison committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    75e1171 View commit details
    Browse the repository at this point in the history