Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set block profile rate #4402

Merged
merged 1 commit into from Aug 16, 2023
Merged

Don't set block profile rate #4402

merged 1 commit into from Aug 16, 2023

Conversation

neilalexander
Copy link
Member

We rarely benefit from block profiles and in many cases a mutex profile will tell us what we need to know. Additionally, setting the block profile rate to 1 has the special meaning of capturing every single blocking event, which can have a fairly significant negative impact on publish performance.

Signed-off-by: Neil Twigg neil@nats.io

@neilalexander
Don't set block profile rate
19397a5 
Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander requested a review from a team as a code owner August 16, 2023 17:30
wallyqs
wallyqs approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekcollison
derekcollison approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 3f28de8 into dev Aug 16, 2023
2 checks passed
@neilalexander neilalexander deleted the neil/blockprofile branch August 16, 2023 18:11
@neilalexander neilalexander mentioned this pull request Sep 25, 2023
Merged
neilalexander added a commit that referenced this pull request Sep 25, 2023
@neilalexander
Add prof_block_rate option for enabling/configuring the block profi…
62faa18 
…le (#4587)

The new `prof_block_rate` configuration option allows the block profiler
to be enabled on demand after it was previously disabled in #4402. The
option is also reloadable so that it can be changed after startup.

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neilalexander @wallyqs @derekcollison