Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set block profile rate #4402

Merged
merged 1 commit into from Aug 16, 2023
Merged

Don't set block profile rate #4402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 0 additions & 6 deletions server/server.go
View file
Open in desktop
Expand Up @@ -2093,9 +2093,6 @@ func (s *Server) Start() {
// Pprof http endpoint for the profiler.
if opts.ProfPort != 0 {
s.StartProfiler()
} else {
// Enable blocking profile even if no port defined since profiling is always possible over $SYS requests
runtime.SetBlockProfileRate(1)
}

if opts.ConfigFile != _EMPTY_ {
Expand Down Expand Up @@ -2697,9 +2694,6 @@ func (s *Server) StartProfiler() {
s.profiler = l
s.profilingServer = srv

// Enable blocking profile
runtime.SetBlockProfileRate(1)

go func() {
// if this errors out, it's probably because the server is being shutdown
err := srv.Serve(l)
Expand Down