[FIXED] Fix for panic from a bug in selecting a filestore block in new fs code. #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Sep 12, 2023
…locks > 32 and we used new binary search in NumPending(). The reason would be that we were not accounting for gaps as mb.first.seq can move. The behavior should always return a valid index and mb if seq is inclusive of range from first to last. The panic could orphan held locks for filestore, consumer and possibly stream. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
select-blk-fix
branch
from
491f833
to
244ff44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When num blocks > 32 and we used new binary search in NumPending() we could return -1, nil. If sequence is inclusive this should always return valid index and mb.
The reason we could return -1 would be that we were not accounting for gaps as mb.first.seq can move ahead as first is removed. The panic could orphan held locks for filestore, consumer and possibly stream which would lock up a system, leading to memory growth and unstable behaviors.
Signed-off-by: Derek Collison derek@nats.io